Skip to content

Some 1.12 fixes #1786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 25, 2025
+6 −4
Merged

Some 1.12 fixes #1786

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
96e6b22
Some 1.12 fixes
wsmoses Oct 24, 2025
c2298bd
Apply suggestions from code review
wsmoses Oct 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions ext/ReactantKernelAbstractionsExt.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,12 +109,11 @@ function (obj::KA.Kernel{ReactantBackend})(args...; ndrange=nothing, workgroupsi
return nothing
end

Reactant.@reactant_overlay @noinline Base.@nospecializeinfer function (
Reactant.@reactant_overlay Base.@nospecializeinfer @noinline function (
obj::KA.Kernel{ReactantBackend}
)(
args...; ndrange=nothing, workgroupsize=nothing
@nospecialize args...; ndrange=nothing, workgroupsize=nothing
)
@nospecialize
return Reactant.call_with_reactant(
Reactant.ka_with_reactant, ndrange, workgroupsize, obj, args...
)
Expand Down
5 changes: 4 additions & 1 deletion src/utils.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -610,7 +610,10 @@ end
# using a custom interpreter in type unstable code.
# `redub_arguments` is `(typeof(original_function), map(typeof, original_args_tuple)...)`
function call_with_reactant_generator(
world::UInt, source::LineNumberNode, self, @nospecialize(redub_arguments)
world::UInt,
source::Union{LineNumberNode,Core.Method},
self,
@nospecialize(redub_arguments)
)
@nospecialize
args = redub_arguments
Expand Down
Loading