Update MPI support #2011
Open
Update MPI support #2011
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ymexla_linalg_pass
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| MPI.PROD => MPI_PROD_ENUM, | ||
| MPI.REPLACE => MPI_REPLACE_ENUM, | ||
| MPI.SUM => MPI_SUM_ENUM, | ||
| MPI.NO_OP => MPI_NO_OP_ENUM |
Contributor
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| MPI.NO_OP => MPI_NO_OP_ENUM | |
| MPI.NO_OP => MPI_NO_OP_ENUM, |
| MPI.DOUBLE => MPI_DOUBLE_ENUM, | ||
| MPI.C_FLOAT_COMPLEX => MPI_C_FLOAT_COMPLEX_ENUM, | ||
| MPI.C_DOUBLE_COMPLEX => MPI_C_DOUBLE_COMPLEX_ENUM, | ||
| MPI.C_BOOL => MPI_C_BOOL_ENUM |
Contributor
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| MPI.C_BOOL => MPI_C_BOOL_ENUM | |
| MPI.C_BOOL => MPI_C_BOOL_ENUM, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, MPI commands were lowered directly to LLVM inside Reactant. In this PR, we instead first lower to a set of MPI Ops defined in Enzyme-JAX by calling the generated MLIR bindings, then invoke the lowering passes (also defined in Enzyme-JAX) to lower from the EnzymeXLA Ops to LLVM.
Currently supported MPI commands are
MPI_Comm_rank
MPI_Comm_size
MPI_Barrier
MPI_Send
MPI_Recv
MPI_Isend
MPI_Irecv
MPI_Wait
MPI_Allreduce
Note: Currently only MPI_COMM_WORLD is the only communicator supported