fix Context leak
#2048
Closed
fix Context leak
#2048
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
currently erroring on |
Collaborator
Author
|
a stacktrace with debug symbols shows new info: it seems like the error triggers on the finalizer of UPDATE: this has been fixed by adding a fake dependency between |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| end | ||
|
|
||
| # use types from API to avoid interfering with GC | ||
| const __context_gc_module = Dict{API.MlirContext, Set{API.MlirModule}}() |
Contributor
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| const __context_gc_module = Dict{API.MlirContext, Set{API.MlirModule}}() | |
| const __context_gc_module = Dict{API.MlirContext,Set{API.MlirModule}}() |
Collaborator
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #319
changes
Contextnow records ownership and callsmlirContextDestroyon finalization ifowner == truecontextmethods onAffineExpr,AffineMap,Attribute,Dialect,Identifier,IntegerSet,Location,Module,OperationandTypenow return a non-ownedContextremovedactivate!,deactivate!in favor ofwith_context, to avoid leakagereplaced the task-local storage of theContextstack with aScopedValueModuleleak by adding a fake dependencyOperationleak