Draft
Conversation
|
This doesn't precompile atm but I suspect this would work |
giordano
reviewed
Jan 23, 2026
| struct var"#Any" | ||
| mutable struct var"#Any" | ||
| type_url::String | ||
| value::Vector{UInt8} |
Member
There was a problem hiding this comment.
For all the immutable structs that have been changed to mutable, fields should be marked as constant, otherwise they lose their property. Also, I'm not sure this is necessary for small structs like this one with 1-2 fields (these aren't even parametric)
There was a problem hiding this comment.
It’s unclear where the line is. Though that one looks too small
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@gbaraldi would something like this work?