fix: convert AbstractRange to concrete types (#2276)#2309
Open
KookiesNKareem wants to merge 1 commit intoEnzymeAD:mainfrom
Open
fix: convert AbstractRange to concrete types (#2276)#2309KookiesNKareem wants to merge 1 commit intoEnzymeAD:mainfrom
KookiesNKareem wants to merge 1 commit intoEnzymeAD:mainfrom
Conversation
avik-pal
reviewed
Jan 30, 2026
Comment on lines
+10
to
+13
| r = range(1.0f0, 10.0f0; length=10) | ||
| a = Reactant.to_rarray(r) | ||
| @test a isa ConcreteRArray{Float32,1} | ||
| @test Array(a) ≈ collect(r) |
Collaborator
There was a problem hiding this comment.
This is not the right solution. Eagerly materializing any structured data structure will hurt perf really bad
Contributor
Author
There was a problem hiding this comment.
Ahh, good point. Would limiting to AbstractRange only also cause performance degradation or no?
Member
There was a problem hiding this comment.
What is the context within which we need the support (eg the root cause of the issue)?
Eg are we materializing a large constant?
Contributor
Author
There was a problem hiding this comment.
I updated to limit only to AbstractRange if this support is needed at all.
KookiesNKareem
force-pushed
the
fix-abstract-range-conversion
branch
from
9493038 to
4ab092b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2276.
AbstractRangetypes (e.g.,range(),reshape(range(...))) toConcreteRArraywhen usingto_rarrayorAdapt.adaptAbstractArrayconstructors forConcretePJRTArrayandConcreteIFRTArrayto_rarray_internalmethods forAbstractArraytypesAdapt.adapt_structureoverrides for range types