Skip to content

Add error checking for device count #2318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wsmoses wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add error checking for device count #2318

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 13 additions & 3 deletions deps/ReactantExtra/API.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2147,24 +2147,34 @@ REACTANT_ABI int ifrt_client_addressable_device_count(ifrt::Client *client) {
}

REACTANT_ABI void ifrt_client_devices(ifrt::Client *client,
ifrt::Device **out_devices) {
ifrt::Device **out_devices,
uint64_t num_devices) {
auto span = client->devices();
if (span.size() != num_devices)
ReactantThrowError("Incorrect number of devices provided");
assert(span.size() == num_devices);
for (int i = 0; i < span.size(); i++) {
out_devices[i] = span[i];
}
}

REACTANT_ABI void ifrt_client_addressable_devices(ifrt::Client *client,
ifrt::Device **out_devices) {
ifrt::Device **out_devices,
uint64_t num_devices) {
auto span = client->addressable_devices();
if (span.size() != num_devices)
ReactantThrowError("Incorrect number of devices provided");
for (int i = 0; i < span.size(); i++) {
out_devices[i] = span[i];
}
}

REACTANT_ABI void ifrt_client_all_devices(ifrt::Client *client,
ifrt::Device **out_devices) {
ifrt::Device **out_devices,
uint64_t num_devices) {
auto span = client->GetAllDevices();
if (span.size() != num_devices)
ReactantThrowError("Incorrect number of devices provided");
for (int i = 0; i < span.size(); i++) {
out_devices[i] = span[i];
}
Expand Down
Loading