Open
Conversation
Member
|
yeah we'll also need traced_type_inner, but the specific error from the issue was the missing make_tracer |
Member
|
concretetotraced we should do the same thing as array [aka if its a memory{T} we will recur on memory(make_tracer(T)), to handle things like memory{concreterarray} but leave alone memory{uint} |
mofeing
force-pushed
the
ss/make_tracer-memory
branch
from
5df790f to
b07d231
Compare
mofeing
commented
Feb 13, 2026
| ] | ||
|
|
||
| if isdefined(Core, :Memory) | ||
| push!(testsuite, (Memory{UInt8}, Memory{UInt8}, Memory{TracedRNumber{UInt8}})) |
Collaborator
Author
There was a problem hiding this comment.
@wsmoses in the other PR, I think you said that converting here to TracedRNumber needs to be discussed because it seems a too edgy case. If so, I agree, but right now it feels awkward that we treat Memory the same as Array except for this point.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| return T isa Core.TypeVar ? UnionAll(traced_T, A´´) : A´´ | ||
| else | ||
| if mode == ArrayToConcrete && T <: ReactantPrimitive | ||
| runtime isa Val{:PJRT} && return ConcretePJRTArray{T,1,_unwrap_val(ndevices)} |
Contributor
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| runtime isa Val{:PJRT} && return ConcretePJRTArray{T,1,_unwrap_val(ndevices)} | |
| runtime isa Val{:PJRT} && | |
| return ConcretePJRTArray{T,1,_unwrap_val(ndevices)} |
|
|
||
| if isdefined(Core, :Memory) | ||
| push!(testsuite, (Memory{UInt8}, Memory{UInt8}, Memory{TracedRNumber{UInt8}})) | ||
| push!(testsuite, (Memory{ConcreteRArray{Float64,1}}, Memory{TracedRArray{Float64,1}}, Memory{TracedRArray{Float64,1}})) |
Contributor
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| push!(testsuite, (Memory{ConcreteRArray{Float64,1}}, Memory{TracedRArray{Float64,1}}, Memory{TracedRArray{Float64,1}})) | |
| push!( | |
| testsuite, | |
| ( | |
| Memory{ConcreteRArray{Float64,1}}, | |
| Memory{TracedRArray{Float64,1}}, | |
| Memory{TracedRArray{Float64,1}}, | |
| ), | |
| ) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #2301
@wsmoses i have doubts about the behavior it should have on different modes:
ArrayToConcrete, it maps toConcreteRArray{T,1}.ConcreteToTracedand other modes, i think it should map to itself.also, unless we return itself always, I think we need a
traced_type_innerrule.