-
Notifications
You must be signed in to change notification settings - Fork 25
CompatHelper: bump compat for ReactantCore to 0.1 for package ., (keep existing compat) #694
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CompatHelper: bump compat for ReactantCore to 0.1 for package ., (keep existing compat) #694
Conversation
…p existing compat)
@@ -74,7 +74,7 @@ Preferences = "1.4" | |||
PythonCall = "0.9" | |||
Random = "1.10" | |||
Random123 = "1.7" | |||
ReactantCore = "0.1.5" | |||
ReactantCore = "0.1.5, 0.1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wut
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounded familiar: JuliaRegistries/CompatHelper.jl#266
For my reference, this looks like the linked CompatHelper run: https://github.com/EnzymeAD/Reactant.jl/actions/runs/13169135948 |
@giordano Could you temporarily modify the CompatHelper config in this repo to point to my debugging branch (JuliaRegistries/CompatHelper.jl#520)? That will let us do debugging in a quicker cycle, without needing to wait for a CompatHelper release every time. |
https://github.com/EnzymeAD/Reactant.jl/actions/runs/13190625523/job/36822782289#step:7:204
Side note, you should be able to work in a fork of this repo without waiting for others to do this, no? |
Is this because ReactantCore 0.1.5 hasn't been registered yet? The suggested change is still silly though. |
Ah, I didn't realize ReactantCore 0.1.5 wasn't registered. Yeah, that's likely the problem. CompatHelper is quite naive, and basically works like this:
CompatHelper was originally designed as a companion to the new AutoMerge rules in the General registry, which is uses the registry as the source of truth for package versions. For this use case (version not registered yet), we'll have to figure out a way to detect this situation. |
The way the PR is generated is also quite naive. First, take the result of step 2, which in this case is Next, if that version number is >= 1.0.0, drop the minor and patch. Otherwise, drop the patch. So in this example, we convert So now we have our "new addition", and we basically just do the equivalent of |
This specific situation (where the compat entry is exactly of the form |
This pull request changes the compat entry for the
ReactantCore
package from0.1.5
to0.1.5, 0.1
for package ..This keeps the compat entries for earlier versions.
Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.