Merged
Conversation
This was referenced Feb 17, 2026
vimarsh6739
force-pushed
the
vim/bazelfix
branch
from
67da84c to
3cf56b5
Compare
vimarsh6739
force-pushed
the
vim/bazelfix
branch
from
3cf56b5 to
761920e
Compare
-only brings in PreserveNVVM from Enzyme -Fixes workspace -Updates Enzyme-JAX
wsmoses
reviewed
Feb 22, 2026
| #include "llvm/Analysis/PostDominators.h" | ||
|
|
||
| #include "PreserveNVVM.h" | ||
| #include "Enzyme/PreserveNVVM.h" |
Member
There was a problem hiding this comment.
in a follow up pr we should rename these files/directories
wsmoses
approved these changes
Feb 22, 2026
Member
wsmoses
left a comment
wsmoses
left a comment
There was a problem hiding this comment.
lgtm but let's wait for ci to pass before merge
Member
Author
|
hmm looks like a linker issue of some kind, let me try to repro |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on EnzymeAD/Enzyme#2705