Skip to content

remove libsqlite3-sys package#115

Open
blacktyger wants to merge 1 commit intoEpicCash:masterfrom
blacktyger:fix-for-libsqlite3-sys
Open

remove libsqlite3-sys package#115
blacktyger wants to merge 1 commit intoEpicCash:masterfrom
blacktyger:fix-for-libsqlite3-sys

Conversation

@blacktyger
Copy link
Contributor

Closes #114

Remove:
libsqlite3-sys = { version = ">=0.8.0, <0.13.0", optional = true, features = ["bundled"] }

from: impls/Cargo.toml, libwallet/Cargo.toml

@blacktyger blacktyger self-assigned this Nov 23, 2024
Copy link
Contributor

@who-biz who-biz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

Copy link
Member

@johanneshahn johanneshahn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fails on windows build.
requires features = ["bundled"]

eg:
sqlite = { version = "0.31.1", features = ["bundled"] }

@blacktyger
Copy link
Contributor Author

fails on windows build. requires features = ["bundled"]

eg: sqlite = { version = "0.31.1", features = ["bundled"] }

Win11, rust 1.81 compiles fine one my side

@who-biz
Copy link
Contributor

who-biz commented Dec 20, 2024

fails to build

works on my machine

Sounds like we need some GitHub actions for Windows builds. I don't own a Windows box that's even close to recently updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] libsqlite3-sys version errors

3 participants