Increases network read timeout to 5 minutes when sending a payment via HTTP#80
Open
NicolasFlamel1 wants to merge 1 commit intoEpicCash:masterfrom
Open
Increases network read timeout to 5 minutes when sending a payment via HTTP#80NicolasFlamel1 wants to merge 1 commit intoEpicCash:masterfrom
NicolasFlamel1 wants to merge 1 commit intoEpicCash:masterfrom
Conversation
Contributor
|
Looks fine to me. Will review once focus shifts back to Ledger integrations. We should test thoroughly to ensure that this does not affect regular network txs adversely. |
Contributor
|
Ledger work on hold indefinitely. We'll see if their listing queue opens up in bull market. Also throwing around the idea of a more privacy-focused Ledger fork. But low priority atm. Open for discussion if we wish to elevate to higher priority. |
who-biz
added
low priority
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change increases the network read timeout to 5 minutes when sending a payment via HTTP. This fixes sending payments to people using the Epic Cash Ledger hardware wallet app which can take up to a minute to create a bulletproof.
The 5 minute read timeout is only applied when sending a
receive_txrequest, and all other requests will still use the default read timeout. This avoids any unnecessary waiting when sending a payment since acheck_versionrequest always comes before areceive_txrequest.