Skip to content

Fix infra scripts when a space is in the file path.#510

Merged
mcottontensor merged 1 commit intoEpicGamesExt:masterfrom
aussiedwarf:space_in_file_path
Feb 26, 2025
Merged

Fix infra scripts when a space is in the file path.#510
mcottontensor merged 1 commit intoEpicGamesExt:masterfrom
aussiedwarf:space_in_file_path

Conversation

@aussiedwarf
Copy link
Copy Markdown
Contributor

@aussiedwarf aussiedwarf commented Feb 26, 2025

Relevant components:

  • Signalling server
  • Common library
  • Frontend library
  • Frontend UI library
  • Matchmaker
  • Platform scripts
  • SFU

Problem statement:

Unable to run scripts on mac and linux with space in file path.

Solution

This fix adds quotes around paths in the platform bash scripts.

fixes #507

Add quotes to multiple places in the scripts to handle spaces.
@lukehb lukehb added auto-backport Used to specify we want a PR to auto backport to a branch, must be paired with auto-backport-to-UEX. auto-backport-to-UE5.4 Auto backport to UE 5.4 auto-backport-to-UE5.3 Auto backport to UE 5.3 auto-backport-to-UE5.5 labels Feb 26, 2025
@mcottontensor mcottontensor merged commit e25fffd into EpicGamesExt:master Feb 26, 2025
12 checks passed
@mcottontensor
Copy link
Copy Markdown
Collaborator

Sidenote: Paths with spaces? Gross.

@github-actions
Copy link
Copy Markdown
Contributor

💔 Some backports could not be created

Status Branch Result
UE5.4 Backport failed because of merge conflicts
UE5.3 Backport failed because of merge conflicts
UE5.5

Note: Successful backport PRs will be merged automatically after passing CI.

Manual backport

To create the backport manually run:

backport --pr 510

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

@mcottontensor
Copy link
Copy Markdown
Collaborator

Older scripts will need different changes due to large changes at 5.5

mcottontensor added a commit that referenced this pull request Feb 26, 2025
[UE5.5] Merge pull request #510 from aussiedwarf/space_in_file_path
@lukehb
Copy link
Copy Markdown
Contributor

lukehb commented Feb 26, 2025

Older scripts will need different changes due to large changes at 5.5

All good to skip then

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-backport Used to specify we want a PR to auto backport to a branch, must be paired with auto-backport-to-UEX. auto-backport-to-UE5.3 Auto backport to UE 5.3 auto-backport-to-UE5.4 Auto backport to UE 5.4 auto-backport-to-UE5.5

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] - Unable to run scripts on mac with space in file path

3 participants