Make abs-capture-time flag false by default#516
Merged
mcottontensor merged 1 commit intomasterfrom Mar 2, 2025
Merged
Conversation
…ty with outdated Chromium clients
lukehb
added
auto-backport
3 tasks
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
mcottontensor
added a commit
that referenced
this pull request
Mar 2, 2025
[UE5.5] Merge pull request #516 from EpicGamesExt/abscapturefix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relevant components:
Problem statement:
abs-capture-timeflag is an opt-in flag, the default should be false, so users can opt-in should they so wish. Due to the flag currently being true this is causing issues with older Chromium clients that do not yet support abs-capture-time #425 (comment)This will not impact latency calculations feature added in #425 as these use the video-timing RTP header extension presently (which we do not have to enable).
Solution
Flag is made
falseby default.Documentation
N/A
Test Plan and Compatibility
Unit tests exist for this flag. If they pass that should be sufficient.