-
Notifications
You must be signed in to change notification settings - Fork 190
Action audit #565
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Action audit #565
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2,14 +2,6 @@ name: Check health of frontend | |
|
|
||
| on: | ||
| workflow_dispatch: | ||
| push: | ||
| paths: | ||
| - ".github/workflows/healthcheck-frontend.yml" | ||
| - "Common/**" | ||
| - "Frontend/**" | ||
| - "Signalling/**" | ||
| - "SignallingWebServer/**" | ||
| - "Extras/**" | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Okay, so we are saying only do healthcheck on PR now. I think that makes sense.
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yeah. Generally the only way things should get into the repo is via PR and we should only merge the PR if the actions pass. So there should be no reason to do it on push. |
||
| pull_request: | ||
| paths: | ||
| - ".github/workflows/healthcheck-frontend.yml" | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point!