Skip to content

Fixing dependency issues that arise in the docker image.#601

Merged
mcottontensor merged 1 commit intoEpicGamesExt:masterfrom
mcottontensor:signalling_docker_fix
Apr 29, 2025
Merged

Fixing dependency issues that arise in the docker image.#601
mcottontensor merged 1 commit intoEpicGamesExt:masterfrom
mcottontensor:signalling_docker_fix

Conversation

@mcottontensor
Copy link
Copy Markdown
Collaborator

Relevant components:

  • Signalling server
  • Common library
  • Frontend library
  • Frontend UI library
  • Matchmaker
  • Platform scripts
  • SFU

Problem statement:

Occasionally when building the signalling docker image, package issues could randomly show up.

Solution

This was simply caused by the fact that the package-lock file was not copied into the image. This change copies that file in which locks the packages to known working configurations.

The dockerfile didn't previously copy in the package-lock file which
means package dependency issues could occasionally arise. This is fixed
by simply copying in the package-lock file.
@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Apr 27, 2025

⚠️ No Changeset found

Latest commit: f6644bf

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@lukehb
Copy link
Copy Markdown
Contributor

lukehb commented Apr 28, 2025

@mcottontensor Look's good to me. Does this need a changeset? Wdyt?

@mcottontensor
Copy link
Copy Markdown
Collaborator Author

Nah no real change just a fixed config.

@mcottontensor mcottontensor added auto-backport Used to specify we want a PR to auto backport to a branch, must be paired with auto-backport-to-UEX. auto-backport-to-UE5.5 labels Apr 29, 2025
@mcottontensor mcottontensor merged commit ca62a87 into EpicGamesExt:master Apr 29, 2025
10 checks passed
@mcottontensor mcottontensor deleted the signalling_docker_fix branch April 29, 2025 04:41
github-actions bot pushed a commit that referenced this pull request Apr 29, 2025
The dockerfile didn't previously copy in the package-lock file which
means package dependency issues could occasionally arise. This is fixed
by simply copying in the package-lock file.

(cherry picked from commit ca62a87)
@github-actions
Copy link
Copy Markdown
Contributor

💚 All backports created successfully

Status Branch Result
UE5.5

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

mcottontensor added a commit that referenced this pull request Apr 29, 2025
…602)

The dockerfile didn't previously copy in the package-lock file which
means package dependency issues could occasionally arise. This is fixed
by simply copying in the package-lock file.

(cherry picked from commit ca62a87)

Co-authored-by: mcottontensor <80377552+mcottontensor@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-backport Used to specify we want a PR to auto backport to a branch, must be paired with auto-backport-to-UEX. auto-backport-to-UE5.5

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants