Closed
Conversation
Some references were not updated to 5.6. All references should now be pointing to the right UE version. The only entries left appear to be from documentation which will get regenerated at another point.
…api paths on windows.
This is to try to build and publish each package as the previous packages seemed to be broken.
Changed the format of the pre step output so it's more reliable and descriptive so that the actual publish step can properly check for empty publish lists.
This should finally publish properly.
Originally removed so we could isolate the package when we build it for publishing, but we need the package-lock because some packages just will not behave properly and we need the lockfile.
Ok the package.json file needs to be deleted otherwise the packages will try to access the local dependencies which will not be built with the way things are setup currently. We need to remove package.json to force npm to fetch the published packages. By copying the package-lock file we also get the needed benefit of still locking the required packages for the build.
Without this, npm in its infinite wisdom uses .gitignore which ignores items that we definitely want in the published package. How this has been working previously is beyond me.
Types was missing from the dist dir due to the gitignore rules.
We need to keep the package lock file similar to how its done in the publish action. I also split the steps into a matrix so its easier to programatically handle what is happening and when. It should also allow steps to happen in parallel
implementation needs to be handled slightly differently.
…in permissions Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
We were using a pretty old moduleresolution type 'node10' to build the commonjs versions of our libraries. This was causing issues when using some dependencies. Updating it to 'node16' then complains that the module also needs to be 'node16'. I Previously thought that the module type needed to remain 'commonjs' to output cjs libraries but this is incorrect. The module type of 'node16' also allows commonjs output and is more modern so will prevent issues with other modules.
This was not working like it was intended and so has been removed.
Sometimes the publish action will fail because npm cannot find the package we just published. Hopefully by adding a small delay at the end of the publish step npm will get enough time to propagate the package. (cherry picked from commit b6fdbdc) Co-authored-by: mcottontensor <80377552+mcottontensor@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relevant components:
Problem statement:
What problem does this PR address?
Solution
How does this PR solve the problem?
Documentation
If you added a new feature or changed an existing feature please add some documentation here.
Or better yet, link to the relevant
/Docsupdate in your PR.Test Plan and Compatibility
What steps have you taken to ensure this PR maintains compataibility with the existing functionality?
Or better yet, link to the unit tests that accompany this PR.