Skip to content

Fix: incorrect string length when emitting descriptors with non-ASCII characters#758

Merged
mcottontensor merged 1 commit intoEpicGamesExt:masterfrom
Belchy06:uiinteraction-string-length
Jan 14, 2026
Merged

Fix: incorrect string length when emitting descriptors with non-ASCII characters#758
mcottontensor merged 1 commit intoEpicGamesExt:masterfrom
Belchy06:uiinteraction-string-length

Conversation

@Belchy06
Copy link
Copy Markdown
Collaborator

@Belchy06 Belchy06 commented Jan 13, 2026

Relevant components:

  • Signalling server
  • Common library
  • Frontend library
  • Frontend UI library
  • Matchmaker
  • Platform scripts
  • SFU

Problem statement:

As mentioned in #754, when emitting a UI interaction with non-ascii characters, the calculated byteLength is incorrect.

Solution

Remove the unnecessary usage of textEncoder and use the direct string length.

Test Plan and Compatibility

Tested with UE 5.7 (PixelStreaming2)

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Jan 13, 2026 •
edited
Loading

⚠️ No Changeset found

Latest commit: 95d054d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Belchy06 Belchy06 force-pushed the uiinteraction-string-length branch 2 times, most recently from 4b4fd1a to ea2ea39 Compare January 13, 2026 06:26
FloEdelmann
FloEdelmann reviewed Jan 13, 2026
View reviewed changes
@Belchy06 Belchy06 force-pushed the uiinteraction-string-length branch from ea2ea39 to 95d054d Compare January 13, 2026 08:16
@mcottontensor mcottontensor added auto-backport Used to specify we want a PR to auto backport to a branch, must be paired with auto-backport-to-UEX. auto-backport-to-UE5.5 auto-backport-to-UE5.6 auto-backport-to-UE5.7 labels Jan 14, 2026
@mcottontensor mcottontensor merged commit 06528b9 into EpicGamesExt:master Jan 14, 2026
7 checks passed
github-actions bot pushed a commit that referenced this pull request Jan 14, 2026
@Belchy06
Fix: incorrect string length when emitting descriptors with non-latin…
0904bff 
… characters (#758)

(cherry picked from commit 06528b9)
@github-actions github-actions bot mentioned this pull request Jan 14, 2026
Merged
github-actions bot pushed a commit that referenced this pull request Jan 14, 2026
@Belchy06
Fix: incorrect string length when emitting descriptors with non-latin…
2f09677 
… characters (#758)

(cherry picked from commit 06528b9)
@github-actions github-actions bot mentioned this pull request Jan 14, 2026
Merged
github-actions bot pushed a commit that referenced this pull request Jan 14, 2026
@Belchy06
Fix: incorrect string length when emitting descriptors with non-latin…
0b9320a 
… characters (#758)

(cherry picked from commit 06528b9)
@github-actions github-actions bot mentioned this pull request Jan 14, 2026
Merged
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jan 14, 2026

💚 All backports created successfully

Status Branch Result
✅ UE5.5
✅ UE5.6
✅ UE5.7

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

mcottontensor pushed a commit that referenced this pull request Jan 14, 2026
@github-actions @Belchy06
Fix: incorrect string length when emitting descriptors with non-latin…
4355368 
… characters (#758) (#763)

(cherry picked from commit 06528b9)

Co-authored-by: William Belcher <william.belcher@hotmail.com>
mcottontensor pushed a commit that referenced this pull request Jan 14, 2026
@github-actions @Belchy06
Fix: incorrect string length when emitting descriptors with non-latin…
09f53de 
… characters (#758) (#762)

(cherry picked from commit 06528b9)

Co-authored-by: William Belcher <william.belcher@hotmail.com>
mcottontensor pushed a commit that referenced this pull request Jan 14, 2026
@github-actions @Belchy06
Fix: incorrect string length when emitting descriptors with non-latin…
206ea89 
… characters (#758) (#761)

(cherry picked from commit 06528b9)

Co-authored-by: William Belcher <william.belcher@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcottontensor mcottontensor mcottontensor approved these changes

+1 more reviewer

@FloEdelmann FloEdelmann FloEdelmann left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

auto-backport Used to specify we want a PR to auto backport to a branch, must be paired with auto-backport-to-UEX. auto-backport-to-UE5.5 auto-backport-to-UE5.6 auto-backport-to-UE5.7

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Belchy06 @FloEdelmann @mcottontensor