Fixed some issues with the evaluation of casts#733
Open
NoxMentis wants to merge 1 commit intoEpicGamesExt:masterfrom
Open
Fixed some issues with the evaluation of casts#733NoxMentis wants to merge 1 commit intoEpicGamesExt:masterfrom
NoxMentis wants to merge 1 commit intoEpicGamesExt:masterfrom
Conversation
…it integer would truncate all 64 bits. Also fixes an issue where a cast from a 64bit float to a 32bit signed integer would skip the conversion and instead truncate the top 32bits.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are a few issues when parsing cast operations in the watch window. Most notably casting to a signed 64bit integer would truncate the full value:
Not sure if this is an appropriate way to fix it and there seems to be no operation to sign extend values so this is not complete.
For example these expressions still yield different values after the fix:
hex( (s64) ( (s32) 0xff223344ff667788 ) ) = 0xff667788
hex( (s64) (s32) 0xff223344ff667788 ) = -0x998878