Skip to content

Conversation

@bymedeu
Copy link
Contributor

@bymedeu bymedeu commented Oct 24, 2024

Since last time i have:

  • renamed every "Maths" folder in "Maths PC" since a new maths subject was added last year, and will soon be on past exams
  • added almost every subject of the s3 2028 midterm, exept "Ethique", English, "THLR"
  • added the correction of both math subjects
    I might have forgotten to pull and force merge some things, so not sure if your last commit is still on my branch

@bymedeu
Copy link
Contributor Author

bymedeu commented Oct 24, 2024

Seems like the compress PDF files commit worked :)

Copy link
Member

@matiboux matiboux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow this was a pain to review (and I procrastinated a lot, I admit — damn, a month already?).

Next time, please update (merge) your branch with upstream (Epidocs:master) for more readable changelogs. Currently, the files changelog shows new changes as well as changes from your last merged PR because it was not updated since. TLDR: Too much diff with upstream branch.

However, that's not the issue preventing me from merging right now, which is:

Upon review, I've noticed the large added file S3/Midterms/Algo/2028/midterm-2028-s3-algo-subject.pdf. Please compress this file! You can use the provided script in the repo, or external online compression tools.

Still, thank you for your contribution!

@matiboux matiboux self-assigned this Dec 2, 2024
@Nixuge
Copy link

Nixuge commented Oct 21, 2025

Any news? This pr's been stalling for almost a year now

@matiboux
Copy link
Member

Any news? This pr's been stalling for almost a year now

@Nixuge No news on my end.
The TLDR review "Too much diff with upstream branch." still applies to this PR.
And in its state now it got nearly impossible to merge with upstream.
Also, as a maintainer, the author did not grant me write access to their fork, and so I am unable to edit the PR changes.

You are welcome to replicate changes in smaller and cleaner PRs if you'd like.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants