-
Notifications
You must be signed in to change notification settings - Fork 7
Add some more detail to flag allocations #672
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
emielver
wants to merge
2
commits into
main
Choose a base branch
from
emiel/expand-allocations
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this section misrepresents how traffic exposure adjustments work. For instance, changing the traffic allocation to 0% will pass everyone through to the next assignment/allocation (the default variant in most cases), even if they had previously been enrolled.
Also, it's important to state that users will only receive the same variant if they remain in the targeted audience.
For example, imagine you have a flag where free users are randomly split between control and treatment, but paid users "fall through" to the default variant (control). In this case once a user goes from free -> paid, they will stop seeing the treatment. Eppo's SDK does not store any history of who has already been assigned.
Assignments are "idempotent", but not "sticky". That is, for the same inputs to the SDK (user ID, user context), the SDK will return the same value. But if a user's context changes and they are no longer in the targeted audience, Eppo's SDK will not "remember" that they were in treatment earlier.
The SDK does guarantee that if a user was in treatment when traffic exposure was at 5%, that they'll still be in treatment once we ramp to 20% exposure. This is because the hashing for traffic allocation and variant weighting is independent. I think that's what this section is trying to say, but we should be more clear about the limitations