-
Notifications
You must be signed in to change notification settings - Fork 4
quality: parameterize SDK and test-data branches #40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving, but give the on:
section of the workflow a look
push: | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should this be restricted to main
branch?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is just a change in syntax to accommodate multiple triggers. That being said, there's not a lot of consistency across the SDKs here on this, so let's set the bar here.
We want tests to run when a) push to main, b) PR opened, c) PR updated
So, you are right that we can restrict push to branches: main as pull_request
includes the synchronize
event which is triggered by pushing commits to a branch under a PR.
on: | ||
push: | ||
|
||
pull_request: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we need to include '**/*'
as the paths for this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't believe so. paths
provides a way to filter the event trigger and **/*
matches everything which is the same as unfiltered.
ποΈ Fixes FF-3096 towards FF-3085
π―ββοΈ Related PRs
Motivation
Changes are often made to the sdk-test-data repository to capture new behaviours, bugs and edge cases. When these changes are pushed to
main
, the SDKs are cloned locally (locally to the github action running) and their respective tests are run. These tests are set up and run by copies of the SDK test workflows - see sdk-test-data workflow. There are a number of limitations to this setup:sdk-test-data
Description of Changes
This change
π - Each SDK's testing workflow is enhanced into a reusable workflow, exposing parameters for SDK branch and the sdk-test-data branch to use in testing.
External to this Change
sdk-test-data get two testing workflows.