Skip to content

Make UniversalFlagConfigWire.format optional #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 27, 2024
Merged

Make UniversalFlagConfigWire.format optional #76

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
47bd195
Make UniversalFlagConfigWire.format optional
leoromanovsky Nov 25, 2024
386cb41
Update eppo_core/src/ufc/models.rs
leoromanovsky Nov 27, 2024
50b494e
Merge branch 'main' into lr/format-optional
leoromanovsky Nov 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion eppo_core/src/ufc/models.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,8 @@ pub type Timestamp = chrono::DateTime<chrono::Utc>;
pub(crate) struct UniversalFlagConfigWire {
/// When configuration was last updated.
pub created_at: Timestamp,
pub format: AssignmentFormat,
#[serde(default)]
pub format: Option<AssignmentFormat>,
/// Environment this configuration belongs to.
pub environment: Environment,
/// Flags configuration.
Expand Down
Loading