Skip to content

FF-3110 chore: fix perf test #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

FF-3110 chore: fix perf test #70

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4edcbb5
FF-3110 chore: fix perf test
rasendubi Sep 6, 2024
c6257a1
tmp: test CI against fixed branch
rasendubi Sep 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/memory-profile-compare.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ jobs:
- name: Checkout main branch
uses: actions/checkout@v2
with:
ref: 'main'
ref: ff-3110-fix-perf-test
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just for testing. Must be reverted before merge ^


- name: Set up Go (main branch)
uses: actions/setup-go@v2
Expand Down
2 changes: 1 addition & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ profile-memory: test-data
@cd eppoclient && \
{ \
echo "Using OUTFILE_SUFFIX: $$OUTFILE_SUFFIX"; \
go test -run Test_e2e -memprofile ../memprofile$$OUTFILE_SUFFIX.out ./...; \
go test -run Test_e2e -memprofile ../memprofile$$OUTFILE_SUFFIX.out .; \
go tool pprof -text -nodecount=50 ../memprofile$$OUTFILE_SUFFIX.out > ../memprofile$$OUTFILE_SUFFIX.text; \
}

Expand Down
Loading