-
Notifications
You must be signed in to change notification settings - Fork 4
feat: assignment and bandit caching #82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
f913167
adjust test as BaseEppoClient no longer accesses the configuration th…
typotter 3ef59d0
feat: add initialConfiguration to client Builder
typotter 5c29124
drop initial config
typotter e902832
use v3.3.1
typotter 16a1c0f
prep for release
typotter 9b3971c
Assignment and Bandit caching
typotter 4bdb444
merge main
typotter 373ffee
nullable
typotter File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How much of this configuration should we surface to devs?
The cache size or ttl? or the
IAssignmentCache
. Or should we surface as a set of caching options on the builder, similar to JS (ex:withLruAssignmentCaching(100)
,withExpiringCache(10, MINUTES)
etc)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the option of providing convenience methods like
withLruAssignmentCaching
andwithExpiringCache
, however we should also allow users to bring their own implementation ofIAssignmentCache
, so we also need awithAssignmentCache
that takes the interface. EDIT: Looks like you already added it below, so we're good on that one