feat(events): Use new event dispatcher API #103
Conversation
package.json
Outdated
| }, | ||
| "dependencies": { | ||
| "@eppo/js-client-sdk-common": "4.3.0" | ||
| "@eppo/js-client-sdk-common": "https://github.com/Eppo-exp/js-sdk-common.git#0bd1de8d06426d91006cfda5070554001ff1184e" |
There was a problem hiding this comment.
this will eventually point to the next release version of js-client-sdk-common once that's published
| skipInitialPoll: skipInitialRequest, | ||
| }; | ||
| instance.setConfigurationRequestParameters(requestConfiguration); | ||
| instance.setEventDispatcher(newEventDispatcher(apiKey)); |
package.json
Outdated
| }, | ||
| "dependencies": { | ||
| "@eppo/js-client-sdk-common": "4.3.0" | ||
| "@eppo/js-client-sdk-common": "https://github.com/Eppo-exp/js-sdk-common.git#66aa69971c488927297e7aa611300d6dda0fd706" |
There was a problem hiding this comment.
Just a reminder not to check this in
| // eslint-disable-next-line @typescript-eslint/ban-ts-comment | ||
| // @ts-ignore test code | ||
| // noinspection JSConstantReassignment | ||
| navigator.onLine = true; |
There was a problem hiding this comment.
woah cool I didn't even know browsers had this
There was a problem hiding this comment.
🎉 despite the awful onLine casing 🤮
| applicationLogger.error( | ||
| `Failed to parse event queue ${this.name} state. Initializing empty queue.`, | ||
| ); |
There was a problem hiding this comment.
I appreciate the fallback modes (vs exploding)
| for (let i = 0; i < serializedEvent.length; i++) { | ||
| hash = (hash << 5) - hash + serializedEvent.charCodeAt(i); | ||
| hash |= 0; // Convert to 32bit integer | ||
| } |
There was a problem hiding this comment.
Any reason we're doing this ourselves vs some hashing library? Or reusing the hashing code we do for shard numbers?
There was a problem hiding this comment.
good point, actually no reason. I'll look into reusing that
| * Configuration used for initializing the Eppo client | ||
| * @public | ||
| */ | ||
| export interface IClientConfig { |
There was a problem hiding this comment.
Thanks for pulling this out into it's own file, much cleaner 🧼
| skipInitialPoll: skipInitialRequest, | ||
| }; | ||
| instance.setConfigurationRequestParameters(requestConfiguration); | ||
| instance.setEventDispatcher(newEventDispatcher(apiKey)); |
| @@ -0,0 +1,11 @@ | |||
| /* Returns elements from arr until the predicate returns false. */ | |||
| export function takeWhile<T>(arr: T[], predicate: (item: T) => boolean): T[] { | |||
There was a problem hiding this comment.
oh interesting utility method
There was a problem hiding this comment.
poor man's lodash
| }, | ||
| "dependencies": { | ||
| "@eppo/js-client-sdk-common": "4.3.0" | ||
| "@eppo/js-client-sdk-common": "^4.5.0" |
Towards: FF-3608
Towards: FF-3609
Motivation and Context
Hook into Eppo-exp/js-sdk-common#139 to use new event dispatcher API
Description
Integrate new event tracking API
How has this been tested?
Wrote tests