Skip to content

Commit b7882b5

Browse files
committed
drop superfluous interface
1 parent f1db0f1 commit b7882b5

File tree

5 files changed

+12
-38
lines changed

5 files changed

+12
-38
lines changed

src/client/eppo-client.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@ import { TLRUInMemoryAssignmentCache } from '../cache/tlru-in-memory-assignment-
1717
import ConfigurationRequestor from '../configuration-requestor';
1818
import { ConfigurationManager } from '../configuration-store/configuration-manager';
1919
import { IConfigurationStore, ISyncStore } from '../configuration-store/configuration-store';
20-
import { IConfigurationManager } from '../configuration-store/i-configuration-manager';
2120
import { MemoryOnlyConfigurationStore } from '../configuration-store/memory.store';
2221
import {
2322
ConfigurationWireV1,
@@ -144,7 +143,7 @@ export default class EppoClient {
144143
private readonly evaluator = new Evaluator();
145144
private configurationRequestor?: ConfigurationRequestor;
146145
private readonly overrideValidator = new OverrideValidator();
147-
private configurationManager: IConfigurationManager;
146+
private configurationManager: ConfigurationManager;
148147

149148
constructor({
150149
eventDispatcher = new NoOpEventDispatcher(),

src/configuration-requestor.spec.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@ import ApiEndpoints from './api-endpoints';
99
import ConfigurationRequestor from './configuration-requestor';
1010
import { ConfigurationManager } from './configuration-store/configuration-manager';
1111
import { IConfigurationStore } from './configuration-store/configuration-store';
12-
import { IConfigurationManager } from './configuration-store/i-configuration-manager';
1312
import { MemoryOnlyConfigurationStore } from './configuration-store/memory.store';
1413
import FetchHttpClient, {
1514
IBanditParametersResponse,
@@ -24,7 +23,7 @@ describe('ConfigurationRequestor', () => {
2423
let banditVariationStore: IConfigurationStore<BanditVariation[]>;
2524
let banditModelStore: IConfigurationStore<BanditParameters>;
2625
let httpClient: IHttpClient;
27-
let configurationManager: IConfigurationManager;
26+
let configurationManager: ConfigurationManager;
2827
let configurationRequestor: ConfigurationRequestor;
2928

3029
beforeEach(async () => {

src/configuration-requestor.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { IConfigurationManager } from './configuration-store/i-configuration-manager';
1+
import { ConfigurationManager } from './configuration-store/configuration-manager';
22
import { IHttpClient } from './http-client';
33
import { IConfiguration } from './i-configuration';
44
import { BanditReference, BanditParameters } from './interfaces';
@@ -9,7 +9,7 @@ export default class ConfigurationRequestor {
99

1010
constructor(
1111
private readonly httpClient: IHttpClient,
12-
private readonly configurationManager: IConfigurationManager,
12+
private readonly configurationManager: ConfigurationManager,
1313
private readonly fetchBandits: boolean,
1414
) {}
1515

src/configuration-store/configuration-manager.ts

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -13,9 +13,14 @@ import {
1313
} from '../interfaces';
1414

1515
import { IConfigurationStore } from './configuration-store';
16-
import { IConfigurationManager } from './i-configuration-manager';
1716

18-
export class ConfigurationManager implements IConfigurationManager {
17+
export type ConfigurationStoreBundle = {
18+
flagConfigurationStore: IConfigurationStore<Flag | ObfuscatedFlag>;
19+
banditReferenceConfigurationStore?: IConfigurationStore<BanditVariation[]>;
20+
banditConfigurationStore?: IConfigurationStore<BanditParameters>;
21+
};
22+
23+
export class ConfigurationManager {
1924
private configuration: StoreBackedConfiguration;
2025

2126
constructor(
@@ -95,11 +100,7 @@ export class ConfigurationManager implements IConfigurationManager {
95100
);
96101
}
97102

98-
public setConfigurationStores(configStores: {
99-
flagConfigurationStore: IConfigurationStore<Flag | ObfuscatedFlag>;
100-
banditReferenceConfigurationStore?: IConfigurationStore<BanditVariation[]>;
101-
banditConfigurationStore?: IConfigurationStore<BanditParameters>;
102-
}): void {
103+
public setConfigurationStores(configStores: ConfigurationStoreBundle): void {
103104
this.flagConfigurationStore = configStores.flagConfigurationStore;
104105
this.banditReferenceConfigurationStore = configStores.banditReferenceConfigurationStore;
105106
this.banditConfigurationStore = configStores.banditConfigurationStore;

src/configuration-store/i-configuration-manager.ts

Lines changed: 0 additions & 25 deletions
This file was deleted.

0 commit comments

Comments
 (0)