refactor: remove old configuration store

Author: rasendubi

src/client/eppo-client-assignment-details.spec.ts

@@ -2,19 +2,14 @@ import * as fs from 'fs';
 
 import {
   IAssignmentTestCase,
-  MOCK_UFC_RESPONSE_FILE,
   readMockUfcConfiguration,
-  readMockUFCResponse,
 } from '../../test/testHelpers';
-import { MemoryOnlyConfigurationStore } from '../configuration-store/memory.store';
 import { AllocationEvaluationCode } from '../flag-evaluation-details-builder';
-import { Flag, ObfuscatedFlag, Variation, VariationType } from '../interfaces';
+import { Variation, VariationType } from '../interfaces';
 import { OperatorType } from '../rules';
 import { AttributeType } from '../types';
 
 import EppoClient, { IAssignmentDetails } from './eppo-client';
-import { initConfiguration } from './test-utils';
-import { read } from 'fs';
 
 describe('EppoClient get*AssignmentDetails', () => {
   const testStart = Date.now();

src/client/eppo-client-experiment-container.spec.ts

@@ -1,10 +1,7 @@
-import { MOCK_UFC_RESPONSE_FILE, readMockUfcConfiguration, readMockUFCResponse } from '../../test/testHelpers';
+import { readMockUfcConfiguration } from '../../test/testHelpers';
 import * as applicationLogger from '../application-logger';
-import { MemoryOnlyConfigurationStore } from '../configuration-store/memory.store';
-import { Flag, ObfuscatedFlag } from '../interfaces';
 
 import EppoClient, { IContainerExperiment } from './eppo-client';
-import { initConfiguration } from './test-utils';
 
 type Container = { name: string };
 

src/client/eppo-client-with-bandits.spec.ts

@@ -13,10 +13,6 @@ import ApiEndpoints from '../api-endpoints';
 import { IAssignmentEvent, IAssignmentLogger } from '../assignment-logger';
 import { BanditEvaluation, BanditEvaluator } from '../bandit-evaluator';
 import { IBanditEvent, IBanditLogger } from '../bandit-logger';
-import {
-  IPrecomputedConfiguration,
-  IObfuscatedPrecomputedConfigurationResponse,
-} from '../configuration-wire/configuration-wire-types';
 import { Evaluator, FlagEvaluation } from '../evaluator';
 import {
   AllocationEvaluationCode,
@@ -52,16 +48,6 @@ describe('EppoClient Bandits E2E test', () => {
         json: () => Promise.resolve(response),
       });
     }) as jest.Mock;
-
-    // Initialize a configuration requestor
-    const apiEndpoints = new ApiEndpoints({
-      baseUrl: 'http://127.0.0.1:4000',
-      queryParams: {
-        apiKey: 'dummy',
-        sdkName: 'js-client-sdk-common',
-        sdkVersion: '1.0.0',
-      },
-    });
   });
 
   beforeEach(() => {

src/client/eppo-client-with-overrides.spec.ts

@@ -1,6 +1,5 @@
 import { Configuration } from '../configuration';
-import { MemoryOnlyConfigurationStore } from '../configuration-store/memory.store';
-import { Flag, FormatEnum, ObfuscatedFlag, VariationType } from '../interfaces';
+import { Flag, FormatEnum, VariationType } from '../interfaces';
 import * as overrideValidatorModule from '../override-validator';
 
 import EppoClient from './eppo-client';

src/client/eppo-client.precomputed.spec.ts

@@ -1,28 +1,19 @@
-import * as td from 'testdouble';
-
 import {
   MOCK_PRECOMPUTED_WIRE_FILE,
   MOCK_DEOBFUSCATED_PRECOMPUTED_RESPONSE_FILE,
   readMockConfigurationWireResponse,
 } from '../../test/testHelpers';
-import { logger } from '../application-logger';
 import { IAssignmentLogger } from '../assignment-logger';
 import { IBanditLogger } from '../bandit-logger';
 import { Configuration } from '../configuration';
-import { MemoryOnlyConfigurationStore } from '../configuration-store/memory.store';
-import { FormatEnum, VariationType, Variation } from '../interfaces';
-import { BanditActions } from '../types';
 
 import EppoClient from './eppo-client';
 
 describe('EppoClient Precomputed Mode', () => {
   // Read both configurations for test reference
   const precomputedConfigurationWire = readMockConfigurationWireResponse(MOCK_PRECOMPUTED_WIRE_FILE);
   const initialConfiguration = Configuration.fromString(precomputedConfigurationWire);
-  
-  // We only use deobfuscated configuration as a reference, not for creating a client
-  const deobfuscatedPrecomputedWire = readMockConfigurationWireResponse(MOCK_DEOBFUSCATED_PRECOMPUTED_RESPONSE_FILE);
-  
+
   let client: EppoClient;
   let mockAssignmentLogger: jest.Mocked<IAssignmentLogger>;
   let mockBanditLogger: jest.Mocked<IBanditLogger>;

src/client/eppo-client.spec.ts

@@ -3,27 +3,11 @@ import { times } from 'lodash';
 import * as td from 'testdouble';
 
 import {
-  ASSIGNMENT_TEST_DATA_DIR,
-  getTestAssignments,
-  IAssignmentTestCase,
   MOCK_UFC_RESPONSE_FILE,
-  OBFUSCATED_MOCK_UFC_RESPONSE_FILE,
-  readMockUfcConfiguration,
-  readMockUfcObfuscatedConfiguration,
   readMockUFCResponse,
-  SubjectTestCase,
-  testCasesByFileName,
-  validateTestAssignments,
 } from '../../test/testHelpers';
 import { IAssignmentLogger } from '../assignment-logger';
 import { AssignmentCache } from '../cache/abstract-assignment-cache';
-import { ConfigurationStore } from '../configuration-store';
-import { MemoryOnlyConfigurationStore } from '../configuration-store/memory.store';
-import {
-  IConfigurationWire,
-  IObfuscatedPrecomputedConfigurationResponse,
-  ObfuscatedPrecomputedConfigurationResponse,
-} from '../configuration-wire/configuration-wire-types';
 import {
   MAX_EVENT_QUEUE_SIZE,
   DEFAULT_BASE_POLLING_INTERVAL_MS,
@@ -32,12 +16,10 @@ import {
 import { decodePrecomputedFlag } from '../decoding';
 import { Flag, ObfuscatedFlag, VariationType, FormatEnum, Variation } from '../interfaces';
 import { getMD5Hash } from '../obfuscation';
-import { AttributeType } from '../types';
 
 import EppoClient, { checkTypeMatch } from './eppo-client';
 import { Configuration } from '../configuration';
-import { IUniversalFlagConfigResponse } from '../http-client';
-import { ISyncStore } from '../configuration-store/configuration-store';
+import { KVStore, MemoryStore } from '../kvstore';
 
 // Use a known salt to produce deterministic hashes
 const salt = base64.fromUint8Array(new Uint8Array([7, 53, 17, 78]));
@@ -748,12 +730,6 @@ describe('EppoClient E2E test', () => {
     });
 
     it('Does not fetch configurations if the configuration store is unexpired', async () => {
-      class MockStore<T> extends MemoryOnlyConfigurationStore<T> {
-        async isExpired(): Promise<boolean> {
-          return false;
-        }
-      }
-
       // Test needs network fetching approach
       client = new EppoClient({
         sdkKey: requestConfiguration.apiKey,
@@ -953,11 +929,11 @@ describe('EppoClient E2E test', () => {
   describe('flag overrides', () => {
     let client: EppoClient;
     let mockLogger: IAssignmentLogger;
-    let overrideStore: ISyncStore<Variation>;
+    let overrideStore: KVStore<Variation>;
 
     beforeEach(() => {
       mockLogger = td.object<IAssignmentLogger>();
-      overrideStore = new MemoryOnlyConfigurationStore<Variation>();
+      overrideStore = new MemoryStore<Variation>();
       client = new EppoClient({
         sdkKey: 'test',
         sdkName: 'test',

src/client/eppo-client.ts

@@ -17,8 +17,6 @@ import { TLRUInMemoryAssignmentCache } from '../cache/tlru-in-memory-assignment-
 import { Configuration, PrecomputedConfig } from '../configuration';
 import ConfigurationRequestor from '../configuration-requestor';
 import { ConfigurationStore } from '../configuration-store';
-import { ISyncStore } from '../configuration-store/configuration-store';
-import { MemoryOnlyConfigurationStore } from '../configuration-store/memory.store';
 import { IObfuscatedPrecomputedConfigurationResponse } from '../configuration-wire/configuration-wire-types';
 import {
   DEFAULT_BASE_POLLING_INTERVAL_MS,
@@ -88,6 +86,7 @@ import {
 import { decodePrecomputedBandit, decodePrecomputedFlag } from '../decoding';
 import { Subject } from './subject';
 import { generateSalt } from '../salt';
+import { KVStore, MemoryStore } from '../kvstore';
 
 export interface IAssignmentDetails<T extends Variation['value'] | object> {
   variation: T;
@@ -110,7 +109,7 @@ export type EppoClientParameters = {
   // Dispatcher for arbitrary, application-level events (not to be confused with Eppo specific assignment
   // or bandit events). These events are application-specific and captures by EppoClient#track API.
   eventDispatcher?: EventDispatcher;
-  overrideStore?: ISyncStore<Variation>;
+  overrideStore?: KVStore<Variation>;
 
   bandits?: {
     /**
@@ -315,7 +314,7 @@ export default class EppoClient {
   private readonly banditEvaluator = new BanditEvaluator();
   private banditLogger?: IBanditLogger;
   private banditAssignmentCache?: AssignmentCache;
-  private overrideStore?: ISyncStore<Variation>;
+  private overrideStore?: KVStore<Variation>;
   private assignmentLogger?: IAssignmentLogger;
   private assignmentCache?: AssignmentCache;
   // whether to suppress any errors and return default values instead
@@ -638,7 +637,7 @@ export default class EppoClient {
   withOverrides(overrides: Record<FlagKey, Variation> | undefined): EppoClient {
     if (overrides && Object.keys(overrides).length) {
       const copy = shallowClone(this);
-      copy.overrideStore = new MemoryOnlyConfigurationStore<Variation>();
+      copy.overrideStore = new MemoryStore<Variation>();
       copy.overrideStore.setEntries(overrides);
       return copy;
     }
@@ -666,7 +665,7 @@ export default class EppoClient {
     this.eventDispatcher?.attachContext(key, value);
   }
 
-  setOverrideStore(store: ISyncStore<Variation>): void {
+  setOverrideStore(store: KVStore<Variation>): void {
     this.overrideStore = store;
   }
 

src/configuration-requestor.spec.ts

@@ -11,14 +11,12 @@ import { BroadcastChannel } from './broadcast';
 import { ConfigurationFeed } from './configuration-feed';
 import ConfigurationRequestor from './configuration-requestor';
 import { ConfigurationStore } from './configuration-store';
-import { IConfigurationStore } from './configuration-store/configuration-store';
 import FetchHttpClient, {
   IBanditParametersResponse,
   IHttpClient,
   IUniversalFlagConfigResponse,
 } from './http-client';
-import { StoreBackedConfiguration } from './i-configuration';
-import { BanditParameters, BanditVariation, Flag, VariationType } from './interfaces';
+import { BanditParameters } from './interfaces';
 
 const MOCK_PRECOMPUTED_RESPONSE = {
   flags: {

src/configuration-store/index.ts renamed to src/configuration-store.ts

@@ -1,7 +1,7 @@
-import { logger } from '../application-logger';
-import { Configuration } from '../configuration';
-import { ConfigurationFeed } from '../configuration-feed';
-import { BroadcastChannel } from '../broadcast';
+import { logger } from './application-logger';
+import { Configuration } from './configuration';
+import { ConfigurationFeed } from './configuration-feed';
+import { BroadcastChannel } from './broadcast';
 
 export type ActivationStrategy = {
   /**