Skip to content
Merged
Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
97b3531
New interfaces for precomputed response
sameerank Nov 18, 2024
6605107
Fetch and store precomputed flags
sameerank Nov 18, 2024
1df0647
Make hydrateConfigurationStore more reusable
sameerank Nov 18, 2024
f1972ba
Add a precomputed requestor test
sameerank Nov 18, 2024
50fb1ff
Test format in response
sameerank Nov 18, 2024
6c33c36
Tests for the precomputed client
sameerank Nov 19, 2024
50ecf05
Comment for why eval details can be null
sameerank Nov 19, 2024
923ad90
Comment clean up
sameerank Nov 20, 2024
7ae8d99
Merge branch 'main' into sameeran/ff-3566-create-eppoprecomputedclient
sameerank Nov 21, 2024
ec2c33d
tsc fixes
sameerank Nov 21, 2024
68fd729
Fix more tests
sameerank Nov 21, 2024
d7c39cd
Add to exports
sameerank Nov 21, 2024
8ac0001
Include logging for format
sameerank Nov 21, 2024
a266e0b
Fix tsc
sameerank Nov 21, 2024
19b0e1e
Fix test
sameerank Nov 21, 2024
ef4b888
feat: precomputed assignment methods for supported types (#135)
sameerank Nov 21, 2024
9a51064
v4.3.1-alpha.0
sameerank Nov 21, 2024
3b5ceaf
Adjust api endpoing for precomputed
sameerank Nov 21, 2024
f91cf75
Add PrecomputedFlag interface to export
sameerank Nov 21, 2024
73ef818
Log format
sameerank Nov 22, 2024
20f4a7e
Fix test
sameerank Nov 22, 2024
59764a2
v4.3.1-alpha.1
sameerank Nov 22, 2024
e2dcc41
fix: post with http client (#137)
sameerank Nov 22, 2024
8629346
Merge branch 'main' into sameeran/ff-3566-create-eppoprecomputedclient
sameerank Nov 26, 2024
34c1ebe
Fix tsc issue
sameerank Nov 26, 2024
f2c2af8
v4.5.0
sameerank Nov 26, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions src/api-endpoints.ts
Original file line number Diff line number Diff line change
@@ -1,8 +1,13 @@
import { BASE_URL as DEFAULT_BASE_URL, UFC_ENDPOINT, BANDIT_ENDPOINT } from './constants';
import { IQueryParams } from './http-client';
import {
BASE_URL as DEFAULT_BASE_URL,
UFC_ENDPOINT,
BANDIT_ENDPOINT,
PRECOMPUTED_FLAGS_ENDPOINT,
} from './constants';
import { IQueryParams, IQueryParamsWithSubject } from './http-client';

interface IApiEndpointsParams {
queryParams?: IQueryParams;
queryParams?: IQueryParams | IQueryParamsWithSubject;
baseUrl?: string;
}

Expand All @@ -27,4 +32,8 @@ export default class ApiEndpoints {
banditParametersEndpoint(): URL {
return this.endpoint(BANDIT_ENDPOINT);
}

precomputedFlagsEndpoint(): URL {
return this.endpoint(PRECOMPUTED_FLAGS_ENDPOINT);
}
}
4 changes: 2 additions & 2 deletions src/assignment-logger.ts
Original file line number Diff line number Diff line change
Expand Up @@ -50,9 +50,9 @@ export interface IAssignmentEvent {
metaData?: Record<string, unknown>;

/**
* The flag evaluation details
* The flag evaluation details. Null if the flag was precomputed.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it also null if users don't request details?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With this implementation it is always null. The edge compute endpoint would need to provide these details in the response for it to be added here, which is out of scope for this milestone

*/
evaluationDetails: IFlagEvaluationDetails;
evaluationDetails: IFlagEvaluationDetails | null;
}

/**
Expand Down
Loading
Loading