-
Notifications
You must be signed in to change notification settings - Fork 1
feat: create EppoPrecomputedClient #129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 19 commits
97b3531
6605107
1df0647
f1972ba
50fb1ff
6c33c36
50ecf05
923ad90
7ae8d99
ec2c33d
68fd729
d7c39cd
8ac0001
a266e0b
19b0e1e
ef4b888
9a51064
3b5ceaf
f91cf75
73ef818
20f4a7e
59764a2
e2dcc41
8629346
34c1ebe
f2c2af8
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -50,9 +50,9 @@ export interface IAssignmentEvent { | |
metaData?: Record<string, unknown>; | ||
|
||
/** | ||
* The flag evaluation details | ||
* The flag evaluation details. Null if the flag was precomputed. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is it also null if users don't request details? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. With this implementation it is always null. The edge compute endpoint would need to provide these details in the response for it to be added here, which is out of scope for this milestone |
||
*/ | ||
evaluationDetails: IFlagEvaluationDetails; | ||
evaluationDetails: IFlagEvaluationDetails | null; | ||
} | ||
|
||
/** | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will bump this pre-release version with the following changes:
PrecomputedFlag
interface for setting up the memory only store's typePRECOMPUTED_BASE_URL
andPRECOMPUTED_FLAGS_ENDPOINT