fix: post with http client #137
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leoromanovsky
approved these changes
Nov 22, 2024
sameerank
merged commit e2dcc41
into
sameeran/ff-3566-create-eppoprecomputedclient
8 checks passed
sameerank
added a commit
that referenced
this pull request
Nov 26, 2024
* New interfaces for precomputed response * Fetch and store precomputed flags * Make hydrateConfigurationStore more reusable * Add a precomputed requestor test * Test format in response * Tests for the precomputed client * Comment for why eval details can be null * Comment clean up * tsc fixes * Fix more tests * Add to exports * Include logging for format * Fix tsc * Fix test * feat: precomputed assignment methods for supported types (#135) * Add methods for boolean, integer, numeric, and json types * Add tests for typed assignments * Remove eslint warnings * v4.3.1-alpha.0 * Adjust api endpoing for precomputed * Add PrecomputedFlag interface to export * Log format * Fix test * v4.3.1-alpha.1 * fix: post with http client (#137) * Add method for post * Change request to a post * Fix payload format * v4.3.1-alpha.2 * Fix tsc issue * v4.5.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
labels: mergeable
Fixes: #issue
Motivation and Context
Previously was doing a GET request
Description
I confirmed the POST request works by running a script that calls
client.fetchPrecomputedFlagsand then checking that thegetBooleanAssignmentmethod works with an expected flag and assignmentHow has this been tested?