chore: prevent native node functions from leaking to js #158
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greghuels
force-pushed
the
greg/native-node
branch
from
be1764c to
76597c7
Compare
greghuels
commented
Dec 4, 2024
| }, | ||
| }, | ||
| ], | ||
| 'no-restricted-globals': [ |
There was a problem hiding this comment.
This is the rule that was added. Other rules were just sorted alphabetically.
greghuels
force-pushed
the
greg/native-node
branch
2 times, most recently
from
739c65f to
cc41463
Compare
greghuels
force-pushed
the
greg/native-node
branch
from
cc41463 to
8d3a4fb
Compare
sameerank
approved these changes
Dec 4, 2024
| message: "'clearImmediate' unavailable in JavaScript.", | ||
| }, | ||
| { | ||
| name: 'process', |
There was a problem hiding this comment.
👍 although looks like this is showing up in a lint-test-sdk error
There was a problem hiding this comment.
I can write extension specific overrides. One sec; I'll update.
greghuels
force-pushed
the
greg/native-node
branch
from
8d3a4fb to
5065934
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lint checks that prevent Node.js globals from leaking to the JavaScript SDK. The lint job should pass once Eppo-exp/js-client-sdk#115 is merged.