feat(events): New API EppoAssignmentLogger
#217
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felipecsl
changed the title
EppoAssignmentLogger
aarsilv
approved these changes
Feb 24, 2025
felipecsl
changed the title
EppoAssignmentLoggerEppoAssignmentLogger
|
@petzel PTAL |
petzel
approved these changes
Mar 6, 2025
petzel
reviewed
Mar 6, 2025
| experiment: 'experiment-abc', | ||
| variant: 'control', | ||
| entityId: 456, | ||
| holdoutKey: 'holdout-xyz', |
There was a problem hiding this comment.
I see that holdoutKey exists in other tests, but this field does not exist on IAssignmentEvent
There was a problem hiding this comment.
yeah I mentioned this in a code comment, it's confusing. this is the line:
https://github.com/Eppo-exp/js-sdk-common/blob/main/src/assignment-logger.ts#L48
IAssignmentEvent can hold arbitrary key/value pairs from extraLogging in FlagEvaluation
Co-authored-by: Eric Petzel <[email protected]>
Co-authored-by: Eric Petzel <[email protected]>
Co-authored-by: Eric Petzel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
labels: mergeable
Fixes: FF-3993
Motivation and Context
Implement
EppoAssignmentLoggerfor seamless Eppo-managed assignment logging.Description
How has this been tested?
Wrote tests