-
Notifications
You must be signed in to change notification settings - Fork 1
feat(events): New API EppoAssignmentLogger
#217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 5 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
3fba6d7
feat(events): [WIP] New API `EppoAssignmentLogger
felipecsl 01ee04f
minor cleanup
felipecsl 2f18c13
Merge branch 'main' into feat--eppo-assignment-logger
felipecsl 111bb08
add entityId
felipecsl 6ae8a6f
skip tracking if no entityId
felipecsl ec4ac26
Update src/eppo-assignment-logger.ts
felipecsl 4391d52
Update src/eppo-assignment-logger.ts
felipecsl d3f78da
Update src/eppo-assignment-logger.ts
felipecsl bcfbbd8
fix keys
felipecsl 462d110
fix tests
felipecsl 2565794
export EppoAssignmentLogger
felipecsl File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,130 @@ | ||
import { IAssignmentEvent } from './assignment-logger'; | ||
import EppoClient from './client/eppo-client'; | ||
import { IConfigurationStore } from './configuration-store/configuration-store'; | ||
import { EppoAssignmentLogger } from './eppo-assignment-logger'; | ||
import { Flag } from './interfaces'; | ||
|
||
jest.mock('./client/eppo-client'); | ||
|
||
describe('EppoAssignmentLogger', () => { | ||
let mockEppoClient: jest.Mocked<EppoClient>; | ||
let logger: EppoAssignmentLogger; | ||
|
||
beforeEach(() => { | ||
jest.clearAllMocks(); | ||
mockEppoClient = new EppoClient({ | ||
flagConfigurationStore: {} as IConfigurationStore<Flag>, | ||
}) as jest.Mocked<EppoClient>; | ||
mockEppoClient.track = jest.fn(); | ||
logger = new EppoAssignmentLogger(mockEppoClient); | ||
}); | ||
|
||
it('should log assignment events correctly', () => { | ||
// Arrange | ||
const assignmentEvent: IAssignmentEvent = { | ||
subject: 'user-123', | ||
experiment: 'experiment-abc', | ||
variant: 'control', | ||
entityId: 456, | ||
holdoutKey: 'holdout-xyz', | ||
holdoutVariation: 'holdout-variant-1', | ||
allocation: 'allocation-1', | ||
featureFlag: 'feature-flag-1', | ||
variation: 'variation-1', | ||
timestamp: new Date().toISOString(), | ||
subjectAttributes: {}, | ||
format: 'json', | ||
evaluationDetails: null, | ||
}; | ||
|
||
// Act | ||
logger.logAssignment(assignmentEvent); | ||
|
||
// Assert | ||
expect(mockEppoClient.track).toHaveBeenCalledTimes(1); | ||
expect(mockEppoClient.track).toHaveBeenCalledWith('__eppo_assignment', { | ||
subject_id: 'user-123', | ||
experiment: 'experiment-abc', | ||
variant: 'control', | ||
entity_id: 456, | ||
holdout: 'holdout-xyz', | ||
holdout_variant: 'holdout-variant-1', | ||
}); | ||
}); | ||
|
||
it('should handle missing optional fields', () => { | ||
// Arrange | ||
const assignmentEvent: IAssignmentEvent = { | ||
subject: 'user-123', | ||
experiment: 'experiment-abc', | ||
variant: 'control', | ||
entityId: 789, | ||
allocation: 'allocation-1', | ||
featureFlag: 'feature-flag-1', | ||
variation: 'variation-1', | ||
timestamp: new Date().toISOString(), | ||
subjectAttributes: {}, | ||
format: 'json', | ||
evaluationDetails: null, | ||
}; | ||
|
||
// Act | ||
logger.logAssignment(assignmentEvent); | ||
|
||
// Assert | ||
expect(mockEppoClient.track).toHaveBeenCalledTimes(1); | ||
expect(mockEppoClient.track).toHaveBeenCalledWith('__eppo_assignment', { | ||
subject_id: 'user-123', | ||
experiment: 'experiment-abc', | ||
variant: 'control', | ||
entity_id: 789, | ||
holdout: undefined, | ||
holdout_variant: undefined, | ||
}); | ||
}); | ||
|
||
it('should skip tracking when entityId is null', () => { | ||
// Arrange | ||
const assignmentEvent: IAssignmentEvent = { | ||
subject: 'user-123', | ||
experiment: 'experiment-abc', | ||
variant: 'control', | ||
entityId: null, | ||
allocation: 'allocation-1', | ||
featureFlag: 'feature-flag-1', | ||
variation: 'variation-1', | ||
timestamp: new Date().toISOString(), | ||
subjectAttributes: {}, | ||
format: 'json', | ||
evaluationDetails: null, | ||
}; | ||
|
||
// Act | ||
logger.logAssignment(assignmentEvent); | ||
|
||
// Assert | ||
expect(mockEppoClient.track).not.toHaveBeenCalled(); | ||
}); | ||
|
||
it('should skip tracking when entityId is undefined', () => { | ||
// Arrange | ||
const assignmentEvent: IAssignmentEvent = { | ||
subject: 'user-123', | ||
experiment: 'experiment-abc', | ||
variant: 'control', | ||
allocation: 'allocation-1', | ||
featureFlag: 'feature-flag-1', | ||
variation: 'variation-1', | ||
timestamp: new Date().toISOString(), | ||
subjectAttributes: {}, | ||
format: 'json', | ||
evaluationDetails: null, | ||
}; | ||
|
||
// Act | ||
logger.logAssignment(assignmentEvent); | ||
|
||
// Assert | ||
expect(mockEppoClient.track).not.toHaveBeenCalled(); | ||
}); | ||
}); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,37 @@ | ||
import { IAssignmentEvent, IAssignmentLogger } from './assignment-logger'; | ||
import EppoClient from './client/eppo-client'; | ||
|
||
/** | ||
* Tracks an assignment event by submitting it to the Eppo Ingestion API. | ||
* Events are queued up for delivery according to the EppoClient's `EventDispatcher` implementation. | ||
*/ | ||
export class EppoAssignmentLogger implements IAssignmentLogger { | ||
constructor(private readonly eppoClient: EppoClient) {} | ||
|
||
logAssignment(event: IAssignmentEvent): void { | ||
const { | ||
entityId: entity_id, | ||
experiment, | ||
// holdout and holdout_variant come from `extraLogging` in FlagEvaluation | ||
holdoutKey: holdout, | ||
holdoutVariation: holdout_variant, | ||
felipecsl marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
subject: subject_id, | ||
felipecsl marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
variant, | ||
felipecsl marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
} = event; | ||
|
||
// Skip tracking if no entityId | ||
if (!entity_id) { | ||
return; | ||
} | ||
|
||
const payload = { | ||
entity_id, | ||
experiment, | ||
holdout_variant, | ||
holdout, | ||
subject_id, | ||
variant, | ||
}; | ||
this.eppoClient.track('__eppo_assignment', payload); | ||
} | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see that
holdoutKey
exists in other tests, but this field does not exist onIAssignmentEvent
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah I mentioned this in a code comment, it's confusing. this is the line:
https://github.com/Eppo-exp/js-sdk-common/blob/main/src/assignment-logger.ts#L48
IAssignmentEvent
can hold arbitrary key/value pairs fromextraLogging
inFlagEvaluation