Set entityId on flag evaluation
#234
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petzel
force-pushed
the
eric/entity-id-flag-evaluation
branch
from
4b7e842 to
d1b3915
Compare
|
Test failures are caused by |
felipecsl
approved these changes
Mar 7, 2025
| extraLogging: split.extraLogging ?? {}, | ||
| doLog: allocation.doLog, | ||
| flagEvaluationDetails, | ||
| entityId: flag.entityId ?? null, |
Similar fix to js-client#182 is required here. |
PR/235 sent to fix the test suite. |
petzel
force-pushed
the
eric/entity-id-flag-evaluation
branch
from
f631c24 to
2d513d6
Compare
greghuels
reviewed
Mar 11, 2025
| allocationKey: precomputedFlag.allocationKey ?? '', | ||
| extraLogging: precomputedFlag.extraLogging ?? {}, | ||
| doLog: precomputedFlag.doLog, | ||
| entityId: null, |
There was a problem hiding this comment.
Is this something that needs to be returned from the assignments endpoint so that the precomputed client has it available as well?
There was a problem hiding this comment.
In order to support automated event logging for the precomputed mode, yes we'll have to pass that down as well.
greghuels
approved these changes
Mar 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Entity IDs are not being passed through to the assignment logger.
Description
Sets the entity ID on the flag evaluation object.
How has this been tested?