Skip to content

Conversation

typotter
Copy link
Collaborator

@typotter typotter commented Mar 12, 2025


labels: mergeable

Towards FF-4076
📜 Configuration Side Loading

Motivation and Context

Client is looking to use offline init with the node-server SDK as indicated by our docs, however said feature does not exist.

Description

This change implements TODOs in the IConfigurationWire type

  • Add fields for Flag and Bandit config responses
  • Create type safety around the response payload strings

How has this been tested?

  • unit tests

@typotter typotter requested review from aarsilv and rasendubi March 12, 2025 06:43
Copy link
Contributor

@aarsilv aarsilv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for tackling these TODOs!

/**
* Wrapper around an IBanditParametersResponse payload.
*/
readonly bandits?: IConfigResponse<IBanditParametersResponse>;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@typotter typotter merged commit 23ef6e9 into main Mar 13, 2025
8 checks passed
@typotter typotter deleted the tp/ufc-in-config-wire branch March 13, 2025 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants