Skip to content

fix: Network Error in older React Naitve versions #243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 12, 2025
Merged

fix: Network Error in older React Naitve versions #243

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@eppo/js-client-sdk-common",
"version": "4.13.4",
"version": "4.13.5-alpha1",
"description": "Common library for Eppo JavaScript SDKs (web, react native, and node)",
"main": "dist/index.js",
"files": [
Expand Down
11 changes: 9 additions & 2 deletions src/http-client.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,9 +46,16 @@ export interface IBanditParametersResponse {
bandits: Record<string, BanditParameters>;
}

/**
* Fixes issues with url.toString() in older React Native versions
* that leaves a trailing slash in pathname
* @param url URL to stringify
* @returns stringified url
*/
const urlWithNoTrailingSlash = (url: URL) => {
url.pathname = url.pathname.replace(/\/$/, '');
return url.toString();
// Note: URL.pathname does not exist in some React Native JS runtime
// so we have to do string manipulation on the stringified URL
return url.toString().replace(/\/\?/, '?').replace(/\/$/, '');
};

export interface IHttpClient {
Expand Down
Loading