Skip to content

fix: bounded event queue splice behavior #245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 13, 2025
Merged

fix: bounded event queue splice behavior #245

merged 2 commits into from
Mar 13, 2025

Conversation

petzel
Copy link
Contributor

@petzel petzel commented Mar 13, 2025

Description

Callers of the splice method in BoundedEventQueue expect to splice a count of events from the beginning of the array. However, the splice call on the underlying data structure does not include a start index parameter, so it interprets the count variable as the start index.

This new behavior is now in line with ArrayBackedNamedEventQueue which also implements NamedEventQueue

leoromanovsky
leoromanovsky approved these changes Mar 13, 2025
View reviewed changes
Copy link
Member

@leoromanovsky leoromanovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the tests

@petzel petzel merged commit 1d5a1e6 into main Mar 13, 2025
8 checks passed
@petzel petzel deleted the eric/fix-splice-bounded-event-queue branch March 13, 2025 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leoromanovsky leoromanovsky leoromanovsky approved these changes

@greghuels greghuels Awaiting requested review from greghuels

@typotter typotter Awaiting requested review from typotter

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@petzel @leoromanovsky