chore: ban URL due to incompatibilities with React Native's Hermes JS engine #249
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greghuels
commented
Mar 14, 2025
Comment on lines
-55
to
-59
| const urlWithNoTrailingSlash = (url: URL) => { | ||
| // Note: URL.pathname does not exist in some React Native JS runtime | ||
| // so we have to do string manipulation on the stringified URL | ||
| return url.toString().replace(/\/\?/, '?').replace(/\/$/, ''); | ||
| }; |
There was a problem hiding this comment.
Removing the trailing-slash band-aid fix. It worked for this situation, but doesn't account for future usages of URL.
typotter
approved these changes
Mar 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
labels: mergeable
Fixes: FF-4133
Motivation and Context
There are a number of issues with the
URLimplementation in React Native's Heremes JavaScript engine:Creating an instance of URL like: new URL('http://facebook.com') throws an exception react-native#16434.
url.pathname)Description
This PR bans usages of URL via eslint and removes the current usage so that it instead uses URLSearchParams.
How has this been tested?
Tested locally in React Native 0.72