fix: stop polling #292
Merged
fix: stop polling #292
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sameerank
commented
Aug 7, 2025
Comment on lines
+108
to
+111
| if (nextTimer) { | ||
| clearTimeout(nextTimer); | ||
| nextTimer = undefined; | ||
| } |
There was a problem hiding this comment.
Are there any other tests that I can write to check that stopping the poller works. We already have this.
js-sdk-common/src/poller.spec.ts
Lines 181 to 188 in 94c6f67
Any tips? @aarsilv
There was a problem hiding this comment.
Perhaps a test where we call stopPolling() immediately after making the poller but that may be overkill
There was a problem hiding this comment.
jest.getTimerCount may be an option to check how many timers are remaining.
aarsilv
approved these changes
Aug 8, 2025
Comment on lines
+108
to
+111
| if (nextTimer) { | ||
| clearTimeout(nextTimer); | ||
| nextTimer = undefined; | ||
| } |
There was a problem hiding this comment.
Perhaps a test where we call stopPolling() immediately after making the poller but that may be overkill
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
labels: mergeable
Fixes: #issue
Motivation and Context
Description
How has this been documented?
How has this been tested?