Selki/ff3396 expiring bandit cache #80
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rasendubi
approved these changes
Nov 29, 2024
|
Yes, the underlaying implementation of cache is here. In this repo I just want to make sure that the tests are working |
maya-the-mango
requested review from
leoromanovsky,
felipecsl,
giorgiomartini0,
dannymatkovsky and
pavelflux
|
@rasendubi added with |
leoromanovsky
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #issue
Motivation and Context
//: # We want to use an expiring cache for bandits to dedupe ones from the same session e.g., if a user rapidly refreshes or the assignment is used on multiple parts of a page. We think a 10-minute expiration will be a good starting point for this.
Description
//: # Used TLRU cache on init of EppoClient
How has this been tested?
//: # Unit tests