Skip to content

Conversation

typotter
Copy link
Collaborator

@typotter typotter commented Nov 22, 2024

🎟️ towards FF-3085

👯‍♂️ Related PRs

Motivation

Changes are often made to the sdk-test-data repository to capture new behaviours, bugs and edge cases. When these changes are pushed to main, the SDKs are cloned locally (locally to the github action running) and their respective tests are run. These tests are set up and run by copies of the SDK test workflows - see sdk-test-data workflow. There are a number of limitations to this setup:

  • Test steps are copied from the SDK’s respective workflows; changes to the SDK test workflows need to be replicated in sdk-test-data and this is not obvious to devs
  • The SDK tests are not able to run against in-flight changes to sdk-test-data
  • When new test-data is committed that breaks an SDK, that breakage is not surfaced in the SDK’s repository until some action triggers its testing workflow (on demand, on pull-request, etc.).

Description of Changes

  • Refactor testing for multiplatform SDK

External to this Change
🚀 - Each SDK's testing workflow is enhanced into a reusable workflow, exposing parameters for SDK branch and the sdk-test-data branch to use in testing.

"subjectKey": "2",
"subjectAttributes": {},
"assignment": 2,
"assignment": 99,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume this was done to see if the tests would fail and I see in the github actions log that they do.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes- reverted

@typotter typotter changed the title feat: remote trigger eppo-multiplatform tests feat: run eppo-multiplatform tests for in-flight changes Dec 2, 2024
@typotter typotter merged commit 7d92105 into main Dec 3, 2024
@typotter typotter deleted the tp/redgreen/multiplatform branch December 3, 2024 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants