Skip to content

Conversation

typotter
Copy link
Collaborator

@typotter typotter commented Nov 26, 2024

🎟️ towards FF-3085
Ticket FF-3085

👯‍♂️ Related PRs

Motivation

Changes are often made to the sdk-test-data repository to capture new behaviours, bugs and edge cases. When these changes are pushed to main, the SDKs are cloned locally (locally to the github action running) and their respective tests are run. These tests are set up and run by copies of the SDK test workflows - see sdk-test-data workflow. There are a number of limitations to this setup:

  • Test steps are copied from the SDK’s respective workflows; changes to the SDK test workflows need to be replicated in sdk-test-data and this is not obvious to devs
  • The SDK tests are not able to run against in-flight changes to sdk-test-data
  • When new test-data is committed that breaks an SDK, that breakage is not surfaced in the SDK’s repository until some action triggers its testing workflow (on demand, on pull-request, etc.).

Description of Changes

  • add java-common testing to the group!

Repos are green!

External to this Change
🚀 - Each SDK's testing workflow is enhanced into a reusable workflow, exposing parameters for SDK branch and the sdk-test-data branch to use in testing.

@typotter typotter changed the title Tp/redgreen/java common feat: local and remote trigger Java common SDK testing Nov 26, 2024
@typotter typotter requested a review from greghuels November 28, 2024 17:04
Copy link
Contributor

@aarsilv aarsilv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good--will approve once tp/apibranch is merged and then purged from this PR 😛

@typotter
Copy link
Collaborator Author

typotter commented Dec 3, 2024

temp refs removed! ptal!

@typotter typotter requested review from aarsilv and felipecsl December 3, 2024 23:11
@typotter typotter assigned aarsilv and unassigned greghuels Dec 3, 2024
@typotter typotter merged commit 5a62c69 into main Dec 10, 2024
27 of 46 checks passed
@typotter typotter deleted the tp/redgreen/java-common branch December 10, 2024 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants