Skip to content

Fixing uploadProfilePicture to use presignedURLs #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 20, 2025
Merged

Fixing uploadProfilePicture to use presignedURLs #13

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
74c0039
Fixing uploadProfilePicture to use presignedURLs
gwen-f Aug 12, 2025
957c571
exposing the now-empty UploadProfilePictureInput to maintain existing…
gwen-f Aug 12, 2025
6bd0559
Revert "exposing the now-empty UploadProfilePictureInput to maintain …
gwen-f Aug 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions model/profiles.smithy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,13 +76,11 @@ operation UploadProfilePicture {
}

structure UploadProfilePictureInput {
image: String
userId: UserId
}

structure UploadProfilePictureOutput {
message: String
pictureId: String
@required
url_info: PresignedPostData
}

structure UserProfile {
Expand Down
8 changes: 1 addition & 7 deletions python/api_model/types/models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -280,14 +280,8 @@ class UpdateProfileResponseContent(BaseModel):
updatedFields: list[str] | None


class UploadProfilePictureRequestContent(BaseModel):
image: str | None
userId: str | None = Field(None, pattern='^[A-Za-z0-9-]+$')


class UploadProfilePictureResponseContent(BaseModel):
message: str | None
pictureId: str | None
url_info: PresignedPostData


class UserProfile(BaseModel):
Expand Down
8 changes: 1 addition & 7 deletions typescript/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -431,14 +431,8 @@ export type UpdateProfileResponseContent = {
updatedFields?: string[];
};

export type UploadProfilePictureRequestContent = {
image?: string;
userId?: string;
};

export type UploadProfilePictureResponseContent = {
message?: string;
pictureId?: string;
url_info: PresignedPostData;
};

export type UserProfile = {
Expand Down
13 changes: 2 additions & 11 deletions typescript/src/models.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -587,13 +587,8 @@ export interface components {
userId: string;
updatedFields?: string[];
};
UploadProfilePictureRequestContent: {
image?: string;
userId?: string;
};
UploadProfilePictureResponseContent: {
message?: string;
pictureId?: string;
url_info: components["schemas"]["PresignedPostData"];
};
UserProfile: {
userId?: string;
Expand Down Expand Up @@ -1117,11 +1112,7 @@ export interface operations {
path?: never;
cookie?: never;
};
requestBody?: {
content: {
"application/json": components["schemas"]["UploadProfilePictureRequestContent"];
};
};
requestBody?: never;
responses: {
/** @description UploadProfilePicture 200 response */
200: {
Expand Down