-
Notifications
You must be signed in to change notification settings - Fork 0
feat: contract composer apis #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
General Revisions
model/equaliq.smithy
Outdated
@@ -27,6 +27,12 @@ service EqualIQ { | |||
GetContractSignatures | |||
UpdateSignatureStatus | |||
DeleteContractSignature | |||
CreateComposerContract | |||
UpdateComposerContract |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we split out different kinds of updates?
model/equaliq.smithy
Outdated
CreateComposerContract | ||
UpdateComposerContract | ||
ListComposerContracts | ||
GetComposerContract |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we split different kinds of Gets? Maybe we should use Meta vs Content?
@@ -27,6 +27,12 @@ service EqualIQ { | |||
GetContractSignatures | |||
UpdateSignatureStatus | |||
DeleteContractSignature | |||
CreateComposerContract |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we use smithy Resources?
model/equaliq.smithy
Outdated
@@ -98,6 +104,18 @@ enum SignContractResult { | |||
FAILURE | |||
} | |||
|
|||
enum ComposerContractStatus { | |||
DRAFT | |||
FINALIZED |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should treat this more like a cache structure for now:
NEW
CLEAN_IN_VAULT
DIRTY
ARCHIVED
model/equaliq.smithy
Outdated
sectionId: String | ||
name: String | ||
content: String | ||
plainTextSummary: String |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's leave this in the frontend for now
model/equaliq.smithy
Outdated
@@ -698,3 +716,130 @@ structure DeleteContractSignatureOutput { | |||
message: String | |||
} | |||
|
|||
|
|||
structure ComposerContractSection { | |||
sectionId: String |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Enum
model/equaliq.smithy
Outdated
structure ComposerContractSection { | ||
sectionId: String | ||
name: String | ||
content: String |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of 'name'/'content' let's add specific structured type for each section with the required fields.
model/equaliq.smithy
Outdated
} | ||
|
||
list ComposerContractList { | ||
member: ComposerContract |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's split out a Metadata type so that we don't need the full composer data for every item in the list
model/equaliq.smithy
Outdated
@required | ||
title: String | ||
@required | ||
type: ContractType |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should take the input form details as well
…k as they were not exporting properly but built fine
No description provided.