-
Notifications
You must be signed in to change notification settings - Fork 3
fix: make useThrottle resilient to remounting #42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
| Original file line number | Diff line number | Diff line change | ||||||
|---|---|---|---|---|---|---|---|---|
|
|
@@ -213,7 +213,7 @@ describe('useThrottle', () => { | |||||||
| }) | ||||||||
| }) | ||||||||
|
|
||||||||
| it('properly cleans up timeout after unmount', async () => { | ||||||||
| it('cleans up timeout after unmount', async () => { | ||||||||
| const timeoutHandler = jest.fn() | ||||||||
|
|
||||||||
| const { unmount } = renderHook(() => { | ||||||||
|
|
@@ -232,6 +232,26 @@ describe('useThrottle', () => { | |||||||
| expect(clearTimeoutSpy).toHaveBeenCalledTimes(1) | ||||||||
|
Owner
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
See my other comment at |
||||||||
| }) | ||||||||
|
|
||||||||
| it('cleans up and sets up again in strict mode', async () => { | ||||||||
| const timeoutHandler = jest.fn() | ||||||||
|
|
||||||||
| renderHook( | ||||||||
| () => { | ||||||||
| const func = useThrottle(timeoutHandler, 500, { leading: false }) | ||||||||
| useEffect(() => { | ||||||||
| func() | ||||||||
| }, [func]) | ||||||||
| }, | ||||||||
| { reactStrictMode: true } | ||||||||
| ) | ||||||||
|
|
||||||||
| await act(() => { | ||||||||
| jest.runAllTimers() | ||||||||
| }) | ||||||||
|
|
||||||||
| expect(timeoutHandler).toHaveBeenCalledTimes(1) | ||||||||
|
Owner
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
Owner
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I suggest that we test both the execution and cleanup call in both new and old tests. |
||||||||
| }) | ||||||||
|
|
||||||||
| it('returns the timeout id for manual clearance', async () => { | ||||||||
| const timeoutHandler = jest.fn() | ||||||||
|
|
||||||||
|
|
||||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I recently updated the testing library packages, so this is now obsolete.