Skip to content

Bugfix: Hands not recognized outside the screen viewport. #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Bugfix: Hands not recognized outside the screen viewport. #8

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0733047
Bugfix: Hands not recognized outside the screen viewport.
longvision Mar 3, 2023
d193b88
Delete yarn.lock
longvision Mar 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions classes/class03/lib/shared/camera.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,22 +1,25 @@
export const extraHorizontalCaptureAreaInPixels = 600

export default class Camera {
constructor() {
this.video = document.createElement('video')
}

static async init() {
if(!navigator.mediaDevices || !navigator.mediaDevices.getUserMedia) {
if (!navigator.mediaDevices || !navigator.mediaDevices.getUserMedia) {
throw new Error(
`Browser API navigator.mediaDevices.getUserMedia not available`
)
}
const videoConfig = {
audio: false,
video: {
width: globalThis.screen.availWidth,
width: globalThis.screen.availWidth + extraHorizontalCaptureAreaInPixels,
height: globalThis.screen.availHeight,
frameRate: {
ideal: 60
}
},
transform: `translate(-${extraHorizontalCaptureAreaInPixels}px)`
}
}
const stream = await navigator.mediaDevices.getUserMedia(videoConfig)
Expand Down
5 changes: 3 additions & 2 deletions classes/class03/pages/titles/src/controllers/handGestureController.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import { prepareRunChecker } from "../../../../lib/shared/util.js"
import { prepareRunChecker } from '../../../../lib/shared/util.js'
import { extraHorizontalCaptureAreaInPixels } from '../../../../lib/shared/camera.js'

const { shouldRun: scrollShouldRun } = prepareRunChecker({ timerDelay: 200 })
const { shouldRun: clickShouldRun } = prepareRunChecker({ timerDelay: 300 })
Expand Down Expand Up @@ -46,7 +47,7 @@ export default class HandGestureController {
for await (const { event, x, y } of this.#service.detectGestures(hands)) {
if (event === 'click') {
if (!clickShouldRun()) continue
this.#view.clickOnElement(x, y)
this.#view.clickOnElement(x - extraHorizontalCaptureAreaInPixels / 2, y)

continue
}
Expand Down
13 changes: 8 additions & 5 deletions classes/class03/pages/titles/src/views/handGestureView.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,14 @@
import { extraHorizontalCaptureAreaInPixels } from '../../../../../lib/shared/camera.js'

export default class HandGestureView {
#handsCanvas = document.querySelector('#hands')
#canvasContext = this.#handsCanvas.getContext('2d')
#fingerLookupIndexes
constructor({ fingerLookupIndexes }) {
this.#handsCanvas.width = globalThis.screen.availWidth
this.#handsCanvas.width = globalThis.screen.availWidth + extraHorizontalCaptureAreaInPixels
this.#handsCanvas.height = globalThis.screen.availHeight
this.#fingerLookupIndexes = fingerLookupIndexes
this.#handsCanvas.style.transform = `translate(-${extraHorizontalCaptureAreaInPixels / 2}px)`
}

clearCanvas() {
Expand All @@ -27,11 +30,11 @@ export default class HandGestureView {
this.#drawFingersAndHoverElements(keypoints)
}
}

clickOnElement(x, y) {
const element = document.elementFromPoint(x, y)
if(!element) return;
if (!element) return;

const rect = element.getBoundingClientRect()
const event = new MouseEvent('click', {
view: window,
Expand Down Expand Up @@ -67,7 +70,7 @@ export default class HandGestureView {
// [0] é a palma da mao (wrist)
const [{ x, y }] = points
region.moveTo(x, y)
for(const point of points) {
for (const point of points) {
region.lineTo(point.x, point.y)
}
this.#canvasContext.stroke(region)
Expand Down