Bumpy road complexity metrics #738
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Elimination of duplicate Traverse* bodies via decorator functions. Minor refactors in the McCabe metric calculation, in anticipation of a similar approach with bumpy road metrics. Additional test cases for McCabe.
Order of Stmt and Expr traversal functions changed so that they are grouped together more coherently.
More centralized/flexible type-based scope creation spanning all potential cases; not just specialized functions. Unification of the statement scope stack and the statement stack.
…t even be considered at query level.
…ame, different ctors look the same; therefore they cannot be distinguished during tests.
Elimination of duplicate Traverse* bodies via decorator functions. Minor refactors in the McCabe metric calculation, in anticipation of a similar approach with bumpy road metrics. Additional test cases for McCabe.
Order of Stmt and Expr traversal functions changed so that they are grouped together more coherently.
More centralized/flexible type-based scope creation spanning all potential cases; not just specialized functions. Unification of the statement scope stack and the statement stack.
…t even be considered at query level.
…ame, different ctors look the same; therefore they cannot be distinguished during tests.
These types are only intended for scope-like usage (ctor-dtor pair matters), not the relocation of data.
intjftw
approved these changes
Apr 29, 2024
mcserep
added
Kind: Enhancement 🌟
Plugin: C++
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as #714, but that was merged without squashing the commits. The commits contained several debugging related changes (and their revoke), which should have been squashed before merging it, according to the project guidelines.