Skip to content

Add playerctl support#108

Merged
ErikReider merged 18 commits intoErikReider:mainfrom
jlo62:clean
Mar 1, 2025
Merged

Add playerctl support#108
ErikReider merged 18 commits intoErikReider:mainfrom
jlo62:clean

Conversation

@jlo62
Copy link
Contributor

@jlo62 jlo62 commented Oct 19, 2024

Hi, this adds support for controlling media.

supports:

  • play-pause, play, pause, stop, shuffle, next, prev
  • setting the player that should be controlled

todo:

  • make title configureable, preferable with config file stuff
  • Add config file examples

@ErikReider
Copy link
Owner

Needs rebase off of main

@jlo62 jlo62 changed the title Draft: add playerctl support Add playerctl support Jan 10, 2025
@jlo62
Copy link
Contributor Author

jlo62 commented Jan 10, 2025

@ErikReider This MR should be ready.

The only thing that requires testing is the installing of the config files, I don't want to install it manually on my machine as it interferes with the package manager.

@jlo62
Copy link
Contributor Author

jlo62 commented Jan 10, 2025

Should also close #116 as it adds a documented example

Copy link
Owner

@ErikReider ErikReider left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise, LGTM! :D

@ErikReider
Copy link
Owner

Also rebase off of main please

@ErikReider ErikReider mentioned this pull request Jan 24, 2025
@jlo62
Copy link
Contributor Author

jlo62 commented Jan 24, 2025

I get this error when rebasing off main:

error[E0432]: unresolved import `zbus::ConnectionBuilder`
  --> src/server/main.rs:36:23
   |
36 | use zbus::{interface, ConnectionBuilder};
   |                       ^^^^^^^^^^^^^^^^^ no `ConnectionBuilder` in the root

Copy link
Owner

@ErikReider ErikReider left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, it makes my life easier if you don't force push commits and use proper commit messages :)

@jlo62
Copy link
Contributor Author

jlo62 commented Feb 3, 2025

@ErikReider I reverted the force push (I think I was rebasing off a ancient version that I hadn't updated in a while) ... I also reverted the changes I didn't do manually. glhf I'm sure I overlooked something.

@jlo62
Copy link
Contributor Author

jlo62 commented Feb 27, 2025

@ErikReider gentle ping not to forget...

Copy link
Owner

@ErikReider ErikReider left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for your patience 😅

@ErikReider ErikReider merged commit fced2ee into ErikReider:main Mar 1, 2025
1 check passed
@jlo62 jlo62 mentioned this pull request Sep 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants