Use better rounded divisions#177
Merged
ErikReider merged 2 commits intoErikReider:mainfrom Oct 26, 2025
Merged
Conversation
ErikReider
requested changes
Oct 24, 2025
Contributor
Author
|
Ok, renamed I think this is good to go, switching brightness now looks great on my setup. Btw, I see this warning when changing brightness (which was there before my changes): (swayosd-server:55525): Gtk-WARNING **: 10:58:59.635: GtkGizmo 0x557ce3f4e9f0 (progress) reported min width -2, but sizes must be >= 0 and, not only I don't understand what's causing it, I couldn't make any quick fixes I found online work, such as:
|
Owner
Might be your custom CSS? Not seeing it on my end... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change makes raising/lowering/setting a percent more consistent.
It fixes #175 where, at certain percents, increasing by 1 causes the brightness to flicker or just get stuck.
It does so by rounding the brightness percent to closest integer.