Fix OSD positioning on rotated displays#181
Merged
ErikReider merged 1 commit intoErikReider:mainfrom Nov 21, 2025
Merged
Conversation
Anchor to bottom instead of top edge to avoid issues with window.allocated_height() returning 0 during initialization. The top_margin parameter still works the same way - 0.85 means 85% from top (15% from bottom with bottom anchoring). Improves on b14eba7 which fixed visibility but had positioning issues.
|
++ This change also fixes the issue I'm seeing regarding the positioning of the OSD on my hidpi laptop display (2880x1920) where the OSD only renders between the top and middle of the screen depending on the value of |
|
I'm pretty sure But this certainly is probably the simplest solution... just offset from the bottom. I like it! |
ErikReider
approved these changes
Nov 21, 2025
Owner
ErikReider
left a comment
ErikReider
left a comment
There was a problem hiding this comment.
Smart! Thanks for the quick fix! :D
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Anchor to bottom instead of top edge to avoid issues with window.allocated_height() returning 0 during initialization.
The top_margin parameter still works the same way - 0.85 means 85% from top (15% from bottom with bottom anchoring).
Improves on b14eba7 which fixed visibility but had positioning issues.